Skip to content
This repository was archived by the owner on Dec 5, 2020. It is now read-only.

Some fixes for depends builds.#285

Open
randy-waterhouse wants to merge 4 commits into
BitBoxSwiss:masterfrom
randy-waterhouse:master
Open

Some fixes for depends builds.#285
randy-waterhouse wants to merge 4 commits into
BitBoxSwiss:masterfrom
randy-waterhouse:master

Conversation

@randy-waterhouse

@randy-waterhouse randy-waterhouse commented Sep 4, 2017

Copy link
Copy Markdown

Getting depends builds working again on linux required these fixes for me. Should be useful for others.

@jonasschnelli

jonasschnelli commented Oct 11, 2017

Copy link
Copy Markdown
Member

Thanks and great to see you here!
Will have a look soon.

@hkjn

hkjn commented Jul 28, 2018

Copy link
Copy Markdown

Ping @jonasschnelli, is there a reason these changes were not merged?

I was attempting to compile depends and hit the same issue recently, and was just about to submit a smaller PR (https://github.com/digitalbitbox/dbb-app/compare/master...hkjn:1807-remove-unknown-patch?expand=1) before finding this one.

Fwiw, with this PR or the one above, we get further but depends build still fails with:

fcmatch.c:284:63: error: 'PRI_CHAR_WIDTH_STRONG' undeclared here (not in a function); did you mean 'PRI_WIDTH_STRONG'?
 #define FC_OBJECT(NAME, Type, Cmp) { FC_##NAME##_OBJECT, Cmp, PRI_##NAME##_STRONG, PRI_##NAME##_WEAK },
                                                               ^
fcobjs.h:54:1: note: in expansion of macro 'FC_OBJECT'
 FC_OBJECT (CHAR_WIDTH,  FcTypeInteger, NULL)
 ^~~~~~~~~
fcmatch.c:284:84: error: 'PRI_CHAR_WIDTH_WEAK' undeclared here (not in a function); did you mean 'PRI_WIDTH_WEAK'?
 #define FC_OBJECT(NAME, Type, Cmp) { FC_##NAME##_OBJECT, Cmp, PRI_##NAME##_STRONG, PRI_##NAME##_WEAK },
                                                                                    ^
fcobjs.h:54:1: note: in expansion of macro 'FC_OBJECT'
 FC_OBJECT (CHAR_WIDTH,  FcTypeInteger, NULL)
 ^~~~~~~~~

@hkjn

hkjn commented Aug 4, 2018

Copy link
Copy Markdown

To follow up for any watchers curious about the PR (and issue #298) as well as for posterity, I found out via @benma that the new digitalbitbox app was just released:

If I understand correctly, the bitbox-wallet-app is intended to fully replace dbb-app eventually.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@randy-waterhouse @jonasschnelli @hkjn